From 52290acbf6587f05472a8c9c75adc5b9baf13f24 Mon Sep 17 00:00:00 2001
From: Raphael Werner <raphael.werner@sidion.de>
Date: Mon, 28 Apr 2025 11:52:41 +0200
Subject: [PATCH] Cleaning Fedora Tasks and adding error handling

---
 roles/fedora/tasks/main.yml | 75 +++++++++++++++++++------------------
 1 file changed, 38 insertions(+), 37 deletions(-)

diff --git a/roles/fedora/tasks/main.yml b/roles/fedora/tasks/main.yml
index ce27a76..ad81b18 100644
--- a/roles/fedora/tasks/main.yml
+++ b/roles/fedora/tasks/main.yml
@@ -1,48 +1,49 @@
 ---
 # tasks file for fedora
-# TODO: Block in roles?! um ständige becomes zu verhindern
 
-- name: "Add rpmfustion repo gpg keys"
-  become: yes
-  ansible.builtin.rpm_key:
-    key: "{{ item }}"
-    state: present
-  with_items: "{{ rpmfusion_keys }}"
+- name: "Adding rpmfusion repos"
+  become: true
+  block:
+    - name: "Add rpmfustion repo gpg keys"
+      ansible.builtin.rpm_key:
+        key: "{{ item }}"
+        state: present
+      with_items: "{{ rpmfusion_keys }}"
 
-- name: install the rpmfusion repo packages
-  become: yes
-  dnf:
-    name: "{{ item }}"
-    state: present
-  with_items: "{{ rpmfusion_repos }}"
+    - name: "Install the rpmfusion repo packages"
+      ansible.builtin.dnf:
+        name: "{{ item }}"
+        state: present
+      with_items: "{{ rpmfusion_repos }}"
+
+    rescue:
+    - ansible.builtin.debug:
+        msg: "rpmfusion Repos konnten nicht hinzugefügt werden."
+
+- name: "Remove and install dnf software"
+  become: true
+  block:
+    - name: "Remove unnecassary packages"
+      ansible.builtin.dnf:
+        name: "{{ item }}"
+        state: absent
+      with_items: "{{ rem_packages }}"
 
 
-- name: Remove unnecassary packages
-  become: yes
-  dnf:
-    name: "{{ item }}"
-    state: absent
-  with_items: "{{ rem_packages }}"
+    - name: "Install all current updates"
+      ansible.builtin.dnf:
+        name: "*"
+        state: latest
+
+    - name: "Install packages"
+      ansible.builtin.dnf:
+        name: "{{ item }}"
+        state: present
+      with_items: "{{ packages }}"
 
 
-- name: Install all current updates
-  become: yes
-  dnf:
-    name: "*"
-    state: latest
-
-
-
-- name: Install packages
-  become: yes
-  dnf:
-    name: "{{ item }}"
-    state: present
-  with_items: "{{ packages }}"
-
-
-- name: Install Flatpaks
+- name: "Install Flatpaks"
   flatpak:
     name: "{{ item }}"
     state: present
-  with_items: "{{ flatpaks }}"
\ No newline at end of file
+  with_items: "{{ flatpaks }}"